-
Notifications
You must be signed in to change notification settings - Fork 787
[CI] Don't upload MacOS artifacts #8924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alexbatashev, please, let me know if you have any feedback. |
Actually, I think we should not upload artifacts in the first place. We don't use macos artifacts, so there is no need to upload them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@bader actually, the idea of having artifacts uploaded was that the developers can download them to quickly check something. But since there're no active users or developers, I'm okay to remove artifacts.
I see that clean-up job immediately removes Linux and Windows artifacts after workflow is finished. So, even if we had this idea originally, it doesn't work anymore. |
BTW, you added this configuration. Is it still useful? If no, I prefer to remove it (or at least switch from regular runs to manual). |
@bader I don't have much bandwidth to contribute to SYCL after I left Intel. I wouldn't mind if you disable this configuration completely, or come up with a less frequent schedule. |
Thanks for the feedback. I saw @AlexeySachkov contributed some fixes for MacOS, so I'd like to hear from him before making this change. |
I'm fine with not uploading macOS artifacts, I didn't even know about such functionality. |
No description provided.