Skip to content

[CI] Don't upload MacOS artifacts #8924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2023
Merged

[CI] Don't upload MacOS artifacts #8924

merged 2 commits into from
Apr 3, 2023

Conversation

bader
Copy link
Contributor

@bader bader commented Apr 1, 2023

No description provided.

@bader bader requested a review from a team as a code owner April 1, 2023 04:10
@bader bader requested a review from AlexeySachkov April 1, 2023 04:12
@bader
Copy link
Contributor Author

bader commented Apr 1, 2023

@alexbatashev, please, let me know if you have any feedback.

@bader
Copy link
Contributor Author

bader commented Apr 1, 2023

Actually, I think we should not upload artifacts in the first place. We don't use macos artifacts, so there is no need to upload them.

@bader bader changed the title [CI] Clean-up MacOS artifacts [CI] Don't upload MacOS artifacts Apr 1, 2023
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@bader actually, the idea of having artifacts uploaded was that the developers can download them to quickly check something. But since there're no active users or developers, I'm okay to remove artifacts.

@bader
Copy link
Contributor Author

bader commented Apr 1, 2023

LGTM. @bader actually, the idea of having artifacts uploaded was that the developers can download them to quickly check something. But since there're no active users or developers, I'm okay to remove artifacts.

I see that clean-up job immediately removes Linux and Windows artifacts after workflow is finished. So, even if we had this idea originally, it doesn't work anymore.
#5726

@bader
Copy link
Contributor Author

bader commented Apr 1, 2023

But since there're no active users or developers, I'm okay to remove artifacts.

BTW, you added this configuration. Is it still useful? If no, I prefer to remove it (or at least switch from regular runs to manual).

@alexbatashev
Copy link
Contributor

@bader I don't have much bandwidth to contribute to SYCL after I left Intel. I wouldn't mind if you disable this configuration completely, or come up with a less frequent schedule.

@bader
Copy link
Contributor Author

bader commented Apr 1, 2023

@bader I don't have much bandwidth to contribute to SYCL after I left Intel. I wouldn't mind if you disable this configuration completely, or come up with a less frequent schedule.

Thanks for the feedback. I saw @AlexeySachkov contributed some fixes for MacOS, so I'd like to hear from him before making this change.

@AlexeySachkov
Copy link
Contributor

@bader I don't have much bandwidth to contribute to SYCL after I left Intel. I wouldn't mind if you disable this configuration completely, or come up with a less frequent schedule.

Thanks for the feedback. I saw @AlexeySachkov contributed some fixes for MacOS, so I'd like to hear from him before making this change.

I'm fine with not uploading macOS artifacts, I didn't even know about such functionality.

@bader bader merged commit 481478a into intel:sycl Apr 3, 2023
@bader bader deleted the clean-up branch April 3, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants