[SYCL] Don't synchronize last event if it is discarded #8993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5921,7 +5921,7 @@ pi_result _pi_queue::synchronize() { | |||
| return PI_SUCCESS; | |||
|
|
|||
| // For in-order queue just wait for the last command. | |||
| if (isInOrderQueue()) { | |||
| if (isInOrderQueue() && !LastCommandEvent->IsDiscarded) { | |||
There was a problem hiding this comment.
Why? Isn't ZeEvent still there and can be synced?
There was a problem hiding this comment.
Oh, I guess this is because it may not be host-scope right?
There was a problem hiding this comment.
Yes, this is one of the reasons. And the main reason is that this event may be in reset state. Basically we can't explicitly synchronize discarded pi_event objects.
There was a problem hiding this comment.
OK, but please add some comment about it.
smaslov-intel
approved these changes
Apr 7, 2023
smaslov-intel
approved these changes
Apr 7, 2023
|
Basic/memory-consumption.cpp fail is known: #9008 |
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
Apr 21, 2023
intel#8601 intel#8993 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
Apr 24, 2023
intel#8601 intel#8993 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 3, 2023
intel#8601 intel#8993 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 16, 2023
intel#8601 intel#8993 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 23, 2023
intel#8601 intel#8993 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 26, 2023
intel#8601 intel#8993 Signed-off-by: Jaime Arteaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.