[SYCL] Fix compile error for handler::copy with -fsycl-unnamed-lambda #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
previously approved these changes
Dec 4, 2019
| cl::sycl::buffer<int> Buf(Size); | ||
|
|
||
| Q.submit([&](cl::sycl::handler &CGH) { | ||
| auto Acc = Buf.get_access<cl::sycl::access::mode::write>(CGH); |
There was a problem hiding this comment.
Minor. Not sure that we need so heavy test to just check that there is no compile time error.
There was a problem hiding this comment.
I have removed several RUN lines to leave only compilation for this test.
I would like to leave the code as-is to be able to execute it if it necessary to check that it actually works
Some `copy` methods in handler are implemented via `parallel_for` for host device and hence, we need to have `KernelInfo` struct (provided by integration header) to compile them. This effectively creates cyclic dependency and we already have some kind of a workaround for it for regular mode (without -fsycl-unnamed-lambda). This patch applies the same solution for unnamed lambda mechanism. Signed-off-by: Alexey Sachkov <[email protected]>
AlexeySachkov
force-pushed
the
private/asachkov/fix-handler-copy-with-unnamed-lambda-flag
branch
from
1764595 to
87e0981
Compare
romanovvlad
approved these changes
Dec 5, 2019
AlexeySachkov
deleted the
private/asachkov/fix-handler-copy-with-unnamed-lambda-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
copymethods in handler are implemented viaparallel_forforhost device and hence, we need to have
KernelInfostruct (provided byintegration header) to compile them.
This effectively creates cyclic dependency and we already have some kind
of a workaround for it for regular mode (without -fsycl-unnamed-lambda).
This patch applies the same solution for unnamed lambda mechanism.