[SYCL] Apply /MD and /MDd on Windows only to SYCL and SYCLD targets #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the build errors caused by RuntimeLibrary value inconsistency for LLVM and apps/tests linked with it, e.g. (MT_StaticRelease vs MD_DynamicRelease) in cases when LLVM_USE_CRT_RELEASE is set to MT. In such cases /MD set for sycl lib targets must not affect tests linked with MT version of LLVM. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
sndmitriev
approved these changes
Dec 5, 2019
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Feb 24, 2021
Signed-off-by: Dmitry Sidorov <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@20ba782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the build errors caused by RuntimeLibrary value
inconsistency for LLVM and apps/tests linked with it,
e.g. (MT_StaticRelease vs MD_DynamicRelease) in cases when
LLVM_USE_CRT_RELEASE is set to MT. In such cases /MD set for sycl lib
targets must not affect tests linked with MT version of LLVM.
Signed-off-by: Vyacheslav N Klochkov [email protected]