[SYCL] Don't use project's CMAKE_CXX_FLAGS for in-tree e2e-tests configuration #9075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration It contains all our "-Werror/-W*/etc." that we use to build the project that have nothing to do with our end-to-end tests.
|
Also tagging @frasercrmck because I can't add him to the reviewers. |
| @@ -17,6 +17,7 @@ if(SYCL_TEST_E2E_STANDALONE) | |||
| set(SYCL_CXX_COMPILER ${CMAKE_CXX_COMPILER}) | |||
| else() | |||
| set(SYCL_CXX_COMPILER "${LLVM_BINARY_DIR}/bin/clang++") | |||
| unset(CMAKE_CXX_FLAGS) | |||
There was a problem hiding this comment.
probably should have a comment. The one you put in the PR would suffice.
cperkinsintel
approved these changes
Apr 14, 2023
aelovikov-intel
commented
Apr 14, 2023
|
@intel/llvm-gatekeepers , this PR is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It contains all our "-Werror/-W*/etc." that we use to build the project that have nothing to do with our end-to-end tests.