[ESIMD] Fix compilation errors caused by type_name() function #9092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of static for one of utility functions caused such warnings before:
function 'esimd_test::type_name<unsigned long>' has internal linkage
but is not defined [-Wundefined-internal]
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
turinevgeny
approved these changes
Apr 18, 2023
…ction Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
changed the title
sarnex
approved these changes
Apr 18, 2023
turinevgeny
reviewed
Apr 18, 2023
| @@ -568,7 +568,7 @@ std::unique_ptr<T, USMDeleter> usm_malloc_shared(queue q, int n) { | |||
| return std::move(res); | |||
| } | |||
|
|
|||
| template <class T> static const char *type_name(); | |||
| template <class T> const char *type_name() { return typeid(T).name(); } | |||
There was a problem hiding this comment.
If the function is defined, then likely the warning will not be issued.
There was a problem hiding this comment.
yes, but that 'static' keyword did not seem to be needed for this template function
|
The fail on AMDGPU is unrelated: The fail in Jenkins/Precommit (ProtexIP) showed pass after restart: https://cje-fm-owrp-prod03.devtools.intel.com/satg-ce-compiler-pipelines/blue/organizations/jenkins/SYCL_CI%2Fintel%2FProtexIP/detail/ProtexIP/188/pipeline/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of static for one of utility functions caused such warnings before: function 'esimd_test::type_name' has internal linkage
but is not defined [-Wundefined-internal]
Fixes #8934