[SYCL][L0] Report events as submitted, not running, until they are completed #9094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpleted Signed-off-by: Sergey V Maslov <[email protected]>
jandres742
reviewed
Apr 18, 2023
| // NOTE: We currently cannot tell if command is currently running, so | ||
| // it will always show up "submitted" before it is finally "completed". | ||
| // | ||
| pi_int32 Result = PI_EVENT_SUBMITTED; |
There was a problem hiding this comment.
would doing this mess with timings, for applications querying for the submit_time?
There was a problem hiding this comment.
I don't think so. This is returning "status", not time. So, an event status can now being either "submitted" or "completed". There is a separate interface for querying timestamps of a kernel for all "submit", "start", "end" times:
llvm/sycl/plugins/level_zero/pi_level_zero.cpp
Line 5104 in 836ceec
This is a know issue: #9008 |
againull
approved these changes
Apr 18, 2023
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
Apr 21, 2023
intel#9094 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
Apr 24, 2023
intel#9094 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 3, 2023
intel#9094 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 16, 2023
intel#9094 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 23, 2023
intel#9094 Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 26, 2023
intel#9094 Signed-off-by: Jaime Arteaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.