Skip to content

[X86] Create all-one vector(v8i32) for TESTC(X,~X) == TESTC(X,-1) if … #9096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

yubingex007-a11y
Copy link
Contributor

…X is v8f32

@yubingex007-a11y yubingex007-a11y requested a review from a team as a code owner April 18, 2023 08:35
@AlexeySachkov
Copy link
Contributor

Is there any reason this is not pushed to the upstream llvm/llvm-project repo?

@yubingex007-a11y
Copy link
Contributor Author

yubingex007-a11y commented Apr 18, 2023

Is there any reason this is not pushed to the upstream llvm/llvm-project repo?
some customer would like to fix a bug ASAP since it block their work

@yubingex007-a11y yubingex007-a11y temporarily deployed to aws April 18, 2023 10:18 — with GitHub Actions Inactive
@yubingex007-a11y yubingex007-a11y temporarily deployed to aws April 18, 2023 11:24 — with GitHub Actions Inactive
@yubingex007-a11y
Copy link
Contributor Author

yubingex007-a11y commented Apr 19, 2023

i encounter a issue that i can't cherry-pick  https://reviews.llvm.org/D148608 to intel/llvm since the testcase doesn't match. i guess there is some commits in llorg change the testcase and these commits are not in intel/llvm . 

REF:

; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx | FileCheck %s
;
; testz(~X,Y) -> testc(X,Y)
;

https://github.com/llvm/llvm-project/blob/9356097206a17eb781180d5f895b52f8b0333f8e/llvm/test/CodeGen/X86/combine-testpd.ll#L1-L7

@yubingex007-a11y
Copy link
Contributor Author

yubingex007-a11y commented Apr 19, 2023

i saw there are 3 commits modified llvm/llvm/test/CodeGen/X86/combine-testpd.ll in llorg but these commits are not in intel/llvm.
so it is brutal to cherry-pick all of them. Thus, i remove the testcase changes.
when pulldown coordinator see the commit land on xmain-web it lead to conflict and he will add back the testcases.
@AlexeySachkov

@yubingex007-a11y yubingex007-a11y temporarily deployed to aws April 19, 2023 08:56 — with GitHub Actions Inactive
@yubingex007-a11y yubingex007-a11y temporarily deployed to aws April 19, 2023 09:38 — with GitHub Actions Inactive
@yubingex007-a11y
Copy link
Contributor Author

@AlexeySachkov ping?

@yubingex007-a11y
Copy link
Contributor Author

ping? @AlexeySachkov

Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with cherry-picking this earlier to unblock a customer.

@againull, @FreddyLeaf: FYI. This is a partial cherry-pick of D148608, because we had to adjust tests to avoid cherry-picking more commits. If you encounter conflicts with this patch, they should be resolved by picking community version of the code

@yubingex007-a11y yubingex007-a11y temporarily deployed to aws April 20, 2023 09:17 — with GitHub Actions Inactive
@yubingex007-a11y yubingex007-a11y temporarily deployed to aws April 20, 2023 10:45 — with GitHub Actions Inactive
@againull
Copy link
Contributor

USM/usm_pooling.cpp reported here: #9148

@againull againull merged commit 04e349b into intel:sycl Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants