Skip to content

[SYCL] Perform SubgroupShuffle emulation for vectors of long long and half #9102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 2, 2023
Merged

[SYCL] Perform SubgroupShuffle emulation for vectors of long long and half #9102

merged 16 commits into from
May 2, 2023

Conversation

maksimsab
Copy link
Contributor

No description provided.

@maksimsab maksimsab requested a review from a team as a code owner April 18, 2023 13:39
@maksimsab maksimsab requested a review from bso-intel April 18, 2023 13:39
@maksimsab maksimsab temporarily deployed to aws April 18, 2023 14:44 — with GitHub Actions Inactive
@maksimsab maksimsab temporarily deployed to aws April 18, 2023 15:27 — with GitHub Actions Inactive
@maksimsab maksimsab temporarily deployed to aws April 19, 2023 12:01 — with GitHub Actions Inactive
@maksimsab maksimsab temporarily deployed to aws April 19, 2023 15:24 — with GitHub Actions Inactive
@maksimsab maksimsab temporarily deployed to aws April 19, 2023 17:15 — with GitHub Actions Inactive
@maksimsab
Copy link
Contributor Author

Basic/memory-consumption.cpp is flaky and has been removed here #9063
Also it can be observed that KernelAndProgram/kernel-bundle-get-kernel.cpp and Basic/kernel_info.cpp are failing in other PRs as well.

Hi @bso-intel
Could you please review this PR?

dm-vodopyanov
dm-vodopyanov reviewed Apr 20, 2023
View reviewed changes
@maksimsab maksimsab temporarily deployed to aws April 20, 2023 12:37 — with GitHub Actions Inactive
@maksimsab maksimsab temporarily deployed to aws April 20, 2023 14:58 — with GitHub Actions Inactive
@maksimsab maksimsab temporarily deployed to aws April 20, 2023 16:02 — with GitHub Actions Inactive
dm-vodopyanov
dm-vodopyanov requested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@dm-vodopyanov dm-vodopyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maksimsab please investigate ABI test failure in pre-commit in check-sycl for Windows.

@maksimsab maksimsab temporarily deployed to aws April 21, 2023 12:11 — with GitHub Actions Inactive
@maksimsab maksimsab temporarily deployed to aws April 21, 2023 13:25 — with GitHub Actions Inactive
@maksimsab maksimsab temporarily deployed to aws April 21, 2023 15:11 — with GitHub Actions Inactive
@maksimsab
Copy link
Contributor Author

@dm-vodopyanov I've found that test in CUDA Regression/same_unnamed_kernels.cpp failed here as well: https://github.com/intel/llvm/actions/runs/4765868363/jobs/8472639817

So it isn't related to the change in this PR.

@maksimsab maksimsab temporarily deployed to aws April 21, 2023 16:53 — with GitHub Actions Inactive
dm-vodopyanov
dm-vodopyanov approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@dm-vodopyanov dm-vodopyanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dm-vodopyanov I've found that test in CUDA Regression/same_unnamed_kernels.cpp failed here as well: https://github.com/intel/llvm/actions/runs/4765868363/jobs/8472639817

So it isn't related to the change in this PR.

@maksimsab please, create an issue in intel/llvm and add a tag "cuda"

@maksimsab maksimsab temporarily deployed to aws May 2, 2023 10:24 — with GitHub Actions Inactive
@maksimsab maksimsab temporarily deployed to aws May 2, 2023 11:32 — with GitHub Actions Inactive
@maksimsab
Copy link
Contributor Author

@dm-vodopyanov Hi!
Previously mentioned regression has been fixed by somebody.
Can we merge this one?

@dm-vodopyanov dm-vodopyanov merged commit eeba879 into intel:sycl May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bso-intel bso-intel bso-intel approved these changes

@dm-vodopyanov dm-vodopyanov dm-vodopyanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maksimsab @bso-intel @dm-vodopyanov