[SYCL] Do not install L0 loader #9166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaslov-intel
force-pushed
the
ze_loader
branch
from
95f8b5c to
e01232e
Compare
againull
approved these changes
Apr 24, 2023
smaslov-intel
force-pushed
the
ze_loader
branch
from
e01232e to
a567eff
Compare
smaslov-intel
force-pushed
the
ze_loader
branch
from
a567eff to
123f0ef
Compare
smaslov-intel
changed the title
cperkinsintel
approved these changes
May 5, 2023
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: smaslov <[email protected]>
smaslov-intel
commented
May 10, 2023
smaslov-intel
commented
May 10, 2023
| @@ -30,7 +30,7 @@ runs: | |||
| run: | | |||
| mkdir build-e2e | |||
| set PATH=%GITHUB_WORKSPACE%\install\bin;%PATH% | |||
| cmake -GNinja -B build-e2e -S.\llvm\sycl\test-e2e -DSYCL_TEST_E2E_TARGETS="${{ inputs.targets }}" -DCMAKE_CXX_COMPILER="clang++" -DLLVM_LIT="..\llvm\llvm\utils\lit\lit.py" ${{ inputs.cmake_args }} | |||
| cmake -GNinja -B build-e2e -S.\llvm\sycl\test-e2e -DSYCL_TEST_E2E_TARGETS="${{ inputs.targets }}" -DCMAKE_CXX_COMPILER="clang++" -DLEVEL_ZERO_LIBS_DIR="D:\github\level-zero_win-sdk\lib.fake" -DLLVM_LIT="..\llvm\llvm\utils\lit\lit.py" ${{ inputs.cmake_args }} | |||
There was a problem hiding this comment.
I'm not sure if those changes are actually tested by pre-commit CI. You might need to push your own branch into the repo and modify the pre-commit tasks not to skip on that branch. After that a test PR against your newly pushed branch could actually test this change.
There was a problem hiding this comment.
I specially used "fake" location to check that interop tests fail, so I know it is tested.
smaslov-intel
commented
May 10, 2023
|
@intel/llvm-gatekeepers : I think this can be merged now |
smaslov-intel
added a commit
that referenced
this pull request
May 17, 2023
Currently the L0 loader version, if being installed/used, clashes with L0 validation and L0 GPU driver components already coming from the system. So, do the same for L0 loader. --------- Signed-off-by: Sergey V Maslov <[email protected]> Signed-off-by: smaslov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the L0 loader version, if being installed/used, clashes with L0 validation and L0 GPU driver components already coming from the system. So, do the same for L0 loader.