[SYCL] Add diagnostic on command group with multiple actions #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it is ok to have that check on run time for hard cases. But obvious cases may be detected and reported on compile time. Can we have that diagnostic in compiler? |
I don't see how this case can be detected at compile time. Do you have any ideas? |
I was thinking about counting functions call of command group lambda in SemaSYCL. But it looks like it fill cause false alarms in case of branching in the lamda |
vladimirlaz
previously approved these changes
Dec 9, 2019
Signed-off-by: Vlad Romanov <[email protected]>
romanovvlad
force-pushed
the
private/vromanov/MultActiosnDiag
branch
from
1dcf299 to
7bafe74
Compare
sergey-semenov
approved these changes
Dec 10, 2019
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Mar 5, 2021
Removes excessive kernel code from the test examples. The key
source-level change for re-generating such IR from Intel SYCL is
to use `SYCL_EXTERNAL` function definitions instead of "true"
heterogeneous code. E.g. the following DPC++ code may be used to
generate IR for the AtomicFAdd test:
```
using namespace cl::sycl;
template <typename T>
using atomic_ref_T = ONEAPI::atomic_ref<T, ONEAPI::memory_order::relaxed,
ONEAPI::memory_scope::device,
access::address_space::global_space>;
SYCL_EXTERNAL decltype(auto) AtomicFloatInc(float &Arg) {
atomic_ref_T<float> Atm(Arg);
return Atm.fetch_add(1);
}
SYCL_EXTERNAL decltype(auto) AtomicDoubleInc(double &Arg) {
atomic_ref_T<double> Atm(Arg);
return Atm.fetch_add(1);
}
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@574d5bb
vladimirlaz
pushed a commit
that referenced
this pull request
Mar 30, 2021
Removes excessive kernel code from the test examples. The key
source-level change for re-generating such IR from Intel SYCL is
to use `SYCL_EXTERNAL` function definitions instead of "true"
heterogeneous code. E.g. the following DPC++ code may be used to
generate IR for the AtomicFAdd test:
```
using namespace cl::sycl;
template <typename T>
using atomic_ref_T = ONEAPI::atomic_ref<T, ONEAPI::memory_order::relaxed,
ONEAPI::memory_scope::device,
access::address_space::global_space>;
SYCL_EXTERNAL decltype(auto) AtomicFloatInc(float &Arg) {
atomic_ref_T<float> Atm(Arg);
return Atm.fetch_add(1);
}
SYCL_EXTERNAL decltype(auto) AtomicDoubleInc(double &Arg) {
atomic_ref_T<double> Atm(Arg);
return Atm.fetch_add(1);
}
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@574d5bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vlad Romanov [email protected]