Skip to content

[SYCLNATIVECPU] Re-enable host device #9178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from

Conversation

PietroGhg
Copy link
Contributor

This PR re-enables the host device, making it again available in user code. This is needed by the SYCL Native CPU compiler flow to accelerate SYCL on CPUs. This PR only contains changes needed to re-enable the host device and no changes related to SYCL Native CPU. The changes relative to SYCL Native CPU are contained in a separate PR, which, for ease of review, currently lives in a separate fork, see this. Once this re-enablement PR is merged in, we will re-target the SYCL Native CPU PR to this repo.

This PR in particular:

@dm-vodopyanov
Copy link
Contributor

dm-vodopyanov commented Apr 24, 2023

@gmlueck @jbrodman, this is a PR for re-enabling host device. You may have some comments here as this violates SYCL 2020 spec. In common, do we have some plans for re-enabling host device?

@PietroGhg PietroGhg temporarily deployed to aws April 24, 2023 14:25 — with GitHub Actions Inactive
@PietroGhg PietroGhg temporarily deployed to aws April 24, 2023 15:21 — with GitHub Actions Inactive
@PietroGhg
Copy link
Contributor Author

@gmlueck @jbrodman, this is a PR for re-enabling host device. You may have some comments here as this violates SYCL 2020 spec. In common, do we have some plans for re-enabling host device?

For us this was the quickest way to get kernels to run through the SYCL native CPU path, but I understand the concerns about the 2020 spec and in general maintainability of the host device, so I'm closing this PR while we work on a better solution, thank you

@PietroGhg PietroGhg closed this Apr 24, 2023
@uwedolinsky
Copy link
Contributor

The plan was to use the host device for parts and no longer expose it to the user - so for the current work we've just re-enabled it, and in that PR we then wanted to gradually remove the bits we no longer need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants