Skip to content

[NFC][SYCL] Modernize type traits usage #9183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2023
Merged

[NFC][SYCL] Modernize type traits usage #9183

merged 2 commits into from
Apr 25, 2023

Conversation

aelovikov-intel
Copy link
Contributor 

$ find sycl/include -type f   | xargs -I{} clang-tidy -checks='-*,modernize-type-traits' -fix --fix-errors {}

Followed by manual inspection to revert bugs it introduced.

@aelovikov-intel
[NFC][SYCL] Modernize type traits usage
2a291ab 
```
$ find sycl/include -type f   | xargs -I{} clang-tidy -checks='-*,modernize-type-traits' -fix --fix-errors {}
```

Followed by manual inspection to revert bugs it introduced.
@aelovikov-intel aelovikov-intel requested review from a team and rolandschulz as code owners April 24, 2023 17:51
@aelovikov-intel aelovikov-intel temporarily deployed to aws April 25, 2023 00:06 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws April 25, 2023 02:59 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor Author

CUDA's SYCL :: Regression/same_unnamed_kernels.cpp is known - #9174.

@intel/llvm-gatekeepers , this PR is ready.

cperkinsintel
cperkinsintel approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not immediately relevant, but we still have detail::is_floating_point<>::value out there, and possibly a few others. I believe most of the duplication from std:: to detail:: was removed some time ago, but there are a few stragglers.

@againull againull merged commit 418fcbb into intel:sycl Apr 25, 2023
@aelovikov-intel aelovikov-intel mentioned this pull request Apr 27, 2023
Merged
aelovikov-intel added a commit to aelovikov-intel/llvm that referenced this pull request Apr 27, 2023
@aelovikov-intel
[SYCL] Add workaround for VS2019 to fix test/regression/bit_cast_win.cpp
fc858f5 
We use VS2019 in CI pipeline internally and
intel#9183 and caused a regression. This PR
fixes it.
againull pushed a commit that referenced this pull request Apr 28, 2023
@aelovikov-intel
[SYCL] Add workaround for VS2019 to fix test/regression/bit_cast_win.…
3cb2e1e 
…cpp (#9242)

We use VS2019 in CI pipeline internally and
#9183 and caused a regression. This PR
fixes it.
@aelovikov-intel aelovikov-intel deleted the modernize_type_traits branch May 1, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolandschulz rolandschulz rolandschulz approved these changes

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aelovikov-intel @rolandschulz @cperkinsintel @v-klochkov @againull