Skip to content

[SYCL][FPGA] Add host compilation check to intel-fpga-local test #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 24, 2019

Conversation

vmaksimo
Copy link
Contributor

No description provided.

@vmaksimo vmaksimo requested a review from MrSidims December 10, 2019 08:10
Signed-off-by: Viktoria Maksimova <[email protected]>

Co-Authored-By: Artem Gindinson <[email protected]>
Signed-off-by: Viktoria Maksimova <[email protected]>
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is another example of a test where we might want to split the testing of separate attributes into multiple kernels. In case you're fine with adding a TODO within this PR, please do.

@vmaksimo
Copy link
Contributor Author

Actually, this is another example of a test where we might want to split the testing of separate attributes into multiple kernels. In case you're fine with adding a TODO within this PR, please do.

Actually, I don't think that it's worth it in this case. I agree that it's hard to extend test with LLVM IR source, but for C++/SYCL code there are no such problems.

@AGindinson
Copy link
Contributor

AGindinson commented Dec 23, 2019

Actually, this is another example of a test where we might want to split the testing of separate attributes into multiple kernels. In case you're fine with adding a TODO within this PR, please do.

Actually, I don't think that it's worth it in this case. I agree that it's hard to extend test with LLVM IR source, but for C++/SYCL code there are no such problems.

While updating a thus-structured LLVM IR-based test is obviously worse, one still can feel the pain when reordering the "self-explaining" variable names in the FileCheck directives. Yes, VAR_TWO, VAR_FIVE, I'm talking to you!

@romanovvlad romanovvlad merged commit e0e01ca into intel:sycl Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants