[SYCL][ESIMD] Fix GenXIntrinsic lowering for vectors used as scalars #9211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most cases, we see the following IR for vector spirv intrinsics: ```c++ %0 = load <3 x i64>, <3 x i64> addrspace(4)* @__spirv_BuiltInGlobalInvocationId, align 32 %1 = extractelement <3 x i64> %0, i64 0 // some use of %1, ex: %2 = icmp ult i64 %0, 50 ``` However, if only the first element is used, this may be optimized to: ```c++ %0 = load i64, addrspace(4)* @__spirv_BuiltInGlobalInvocationId, align 32 // some use of %1, ex: %1 = icmp ult i64 %0, 0 ``` In the latter case, if we try to insert a cast due to different types between the real intrinsic type and the global variable type, make sure to use the load type, because the use type is arbitrary code and may not be the same as the global variable type. This is fine for the case with ExtractElement because in that case the return will be based on the global variable type. Signed-off-by: Sarnie, Nick <[email protected]>
not related |
v-klochkov
approved these changes
Apr 26, 2023
Signed-off-by: Sarnie, Nick <[email protected]>
|
This fail is unrelated to this PR with changes in ESIMD lowering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases, we see the following IR for vector spirv intrinsics:
However, if only the first element is used, this may be optimized to:
In the latter case, if we try to insert a cast due to different types between the real intrinsic type and the global variable type, make sure to use the load type, because the use type is arbitrary code and may not be the same as the global variable type.
This is fine for the case with ExtractElement because in that case the type of the EE will be based on the global variable type.