[SYCL] Fix diagnostic about non-globally-visible kernel name #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fznamznon
reviewed
Dec 13, 2019
|
Ping. |
AlexeySachkov
force-pushed
the
private/asachkov/fix-error-about-unnamed-lambda
branch
from
642d069 to
b3a10b3
Compare
bader
reviewed
Feb 18, 2020
AlexeySachkov
force-pushed
the
private/asachkov/fix-error-about-unnamed-lambda
branch
from
b3a10b3 to
2180f4e
Compare
kbobrovs
reviewed
Feb 19, 2020
| kernel_single_task<KernelName2>([=]() { acc.use(); }); | ||
| #endif | ||
|
|
||
| #ifdef LD__ |
There was a problem hiding this comment.
I suggest to convert these ("expected compilation error") to negative compilation tests together with removal. Or leave it as is if there are no resource now.
There was a problem hiding this comment.
I preserved these negative test cases in the new test, this is mentioned in commit message
Fznamznon
reviewed
Feb 20, 2020
| }); | ||
|
|
||
| #ifndef __SYCL_UNNAMED_LAMBDA__ | ||
| // expected-error@16 {{kernel needs to have a globally-visible name}} |
There was a problem hiding this comment.
I suggest to make this diagnostic a bit more informative. It should point to kernel-name class definitions and defective kernel invoke call both.
|
@AlexeySachkov, please, address comments. |
AlexeySachkov
force-pushed
the
private/asachkov/fix-error-about-unnamed-lambda
branch
from
2180f4e to
5b8496b
Compare
bader
previously approved these changes
Mar 20, 2020
|
@AlexeySachkov, please, fix LIT tests. |
Moved some dead code from CodeGenSYCL/int_header1.cpp to the new test Signed-off-by: Alexey Sachkov <[email protected]>
Signed-off-by: Alexey Sachkov <[email protected]>
Signed-off-by: Alexey Sachkov <[email protected]>
Signed-off-by: Alexey Sachkov <[email protected]>
AlexeySachkov
force-pushed
the
private/asachkov/fix-error-about-unnamed-lambda
branch
from
edddd29 to
d410017
Compare
Should be done now |
Fznamznon
approved these changes
Mar 23, 2020
AlexeySachkov
deleted the
private/asachkov/fix-error-about-unnamed-lambda
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved some dead code from CodeGenSYCL/int_header1.cpp to the new test