Skip to content

[SYCL] Fix bug in fill op for zero-dim accessor. #9287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2023

Conversation

maarquitos14
Copy link
Contributor

@maarquitos14 maarquitos14 commented May 3, 2023

According to the SYCL2020 spec, a zero-dim accessor is used for accessing the first element of a buffer. Also, range and id classes cannot accept zero dimensions. Thus, we need a special case for zero-dim accessors that simply fills the first element.

Closes #9252.

@maarquitos14 maarquitos14 requested a review from a team as a code owner May 3, 2023 10:45
@maarquitos14 maarquitos14 requested a review from bso-intel May 3, 2023 10:45
@maarquitos14 maarquitos14 temporarily deployed to aws May 3, 2023 11:21 — with GitHub Actions Inactive
@maarquitos14 maarquitos14 temporarily deployed to aws May 3, 2023 13:33 — with GitHub Actions Inactive
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Maronas, Marcos <[email protected]>
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@maarquitos14 maarquitos14 temporarily deployed to aws May 5, 2023 14:29 — with GitHub Actions Inactive
@maarquitos14 maarquitos14 temporarily deployed to aws May 5, 2023 23:44 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov merged commit 5b46e0d into intel:sycl May 8, 2023
@AlexeySachkov
Copy link
Contributor

Post-commit fix: #9352

aelovikov-intel pushed a commit that referenced this pull request May 8, 2023
This fixes `-Werror` build failure in post-commit after #9287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation failure on sycl::handler::fill with zero-dim accessor
4 participants