[SYCL] Fix DeviceCodeSplit checks to eliminate KernelInfo usage #9316
Conversation
…sage in multiple translation units) Signed-off-by: Tikhomirova, Kseniya <[email protected]>
| Q.submit([&](sycl::handler &Cgh) { | ||
| auto Acc = Buf.get_access<sycl::access::mode::read_write>(Cgh); | ||
| Cgh.single_task<File1Kern1>(/*Krn,*/ [=]() { Acc[0] = 1; }); | ||
| Cgh.single_task<File1Kern1>(Krn1, [=]() { Acc[0] = 1; }); |
There was a problem hiding this comment.
Is this the most important part of the change?
There was a problem hiding this comment.
No, main change is get_kernel_ids usage
SYCL implementation does not properly support KernelInfo usage in multiple translation units. In this test integration header with File1Kern1 is included to main source file where we execute that kernel. In the second file get_kernel_id is used for checks but integration header is not attached to that file since we do not execute kernel there and we got UB because trying to use get_name() function of KI. This problem is a known one. This test doesn;t target to verify this behavior - it is targeted to verify that kernels from different files is added to different device images if we built it with related option. I implemented a different check that do not involve UB case and moreover - enable initially disabled checks because of the problem above. Please reach me out in private if you need more details about issue with KernelInfo usage. |
SYCL implementation does not properly support KernelInfo usage in multiple translation units. In this test integration header with File1Kern1 is included to main source file where we execute that kernel. In the second file get_kernel_id is used for checks but integration header is not attached to that file since we do not execute kernel there and we got UB because trying to use get_name() function of KI. This problem is a known one. This test doesn't target to verify this behavior - it is targeted to verify that kernels from different files is added to different device images if we built it with related option. A different check is implemented that do not involve UB case and enable initially disabled checks because of the problem above.