[SYCL] Report false for aspect::image on all devices #9368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new ext_intel_legacy_image aspect for checking SYCL 1.2.1 image support, the implementation should now refer to the support for SYCL 2020 images when queried for either info::device::image_support or aspect::image. Since there is no current support for device-side SYCL 2020 images, this forces all devices to report false for both of these queries. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
approved these changes
May 9, 2023
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
changed the title
|
Correction; missing symbol was a required specialization due to it being in the |
aelovikov-intel
approved these changes
May 9, 2023
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new ext_intel_legacy_image aspect for checking SYCL 1.2.1 image support, the implementation should now refer to the support for SYCL 2020 images when queried for either info::device::image_support or aspect::image. Since there is no current support for device-side SYCL 2020 images, this forces all devices to report false for both of these queries.