-
Notifications
You must be signed in to change notification settings - Fork 789
[SYCL] Refactor program to improve ABI stability #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Refactor program to improve ABI stability #938
Conversation
std::make_shared<kernel_impl>(get_pi_kernel(KernelName), Context, | ||
PtrToSelf, /*IsCreatedFromSource*/ true)); | ||
} | ||
std::shared_ptr<program_impl> PtrToSelf, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shared_ptr_class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these _class
will probably be deprecated at some point, so I do not thing this change is important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexeySachkov although it is not part of public interface and these methods are not called outside RT (thus no need to use _class
), I still applied your suggestion as it makes call stack more consistent (less conversion between different types).
@keryell that's new information for me. Is there some discussion or any other source of information so I can ramp up myself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talk to your SYCL committee representative. I think the problem is that it is not really implementable in a portable way and not testable with some CTS... So why not just using the STL nowadays?
b8a6435
to
747dee6
Compare
578b8d6
to
0314a6b
Compare
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
0314a6b
to
ef7c05a
Compare
@romanovvlad ping |
This patch is a part of effort to decouple SYCL Runtime library
interface from its actual implementation. The goal is to improve
SYCL ABI/API compatibility between different versions of library.
The following modifications were applied to program and program_impl
classes:
it with forward declaration.
Applying aforementioned changes requires modifying other header files.
While some of those may seem as a regression, affected classes will be
covered by future patches.
Signed-off-by: Alexander Batashev [email protected]