[SYCL] Implement sycl_ext_oneapi_root_group #9396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Aziz <[email protected]>
|
@0x12CC - Could you please add a description detailing what this implements and what it doesn't? It seems like there are a handful of TODO's in here, so it may help us understand how fully implemented the extension is when this is merged. |
Pennycook
requested changes
May 10, 2023
|
@intel/sycl-language-enabling-triage: FYI |
Signed-off-by: Michael Aziz <[email protected]>
Pennycook
approved these changes
May 15, 2023
Signed-off-by: Michael Aziz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the extension proposed in
llvm/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_root_group.asciidoc. The implementation is complete, but themax_num_work_group_syncquery always returns1. The implemented barrier has work group scope since all work items in a root group are currently in the same work group. The twoTODOannotations (in the query and barrier code) can be updated once the backends include the required functionality.