Skip to content

[SYCL] Add sycl wrappers for fp conversions. #9431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented May 12, 2023

This PR adds C++ wrappers in intel math header for type conversion functions provided in SYCL libdevice.
The function names align with CUDA correspondence but we don't use "__" prefix in function name.
For example, CUDA __double2float_ru maps to sycl::ext::intel::math::double2float_ru.

@jinge90 jinge90 requested a review from a team as a code owner May 12, 2023 05:52
@jinge90 jinge90 requested a review from aelovikov-intel May 12, 2023 05:52
@jinge90 jinge90 marked this pull request as draft May 12, 2023 05:52
@jinge90 jinge90 temporarily deployed to aws May 16, 2023 09:45 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws May 16, 2023 10:16 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws May 18, 2023 07:27 — with GitHub Actions Inactive
Signed-off-by: jinge90 <[email protected]>
@jinge90 jinge90 temporarily deployed to aws May 18, 2023 08:15 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws May 18, 2023 08:48 — with GitHub Actions Inactive
jinge90 added 2 commits May 19, 2023 11:02
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
@jinge90 jinge90 temporarily deployed to aws May 19, 2023 09:20 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws May 19, 2023 09:50 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws May 22, 2023 06:28 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws May 22, 2023 07:01 — with GitHub Actions Inactive
@jinge90 jinge90 marked this pull request as ready for review June 1, 2023 01:55
@jinge90
Copy link
Contributor Author

jinge90 commented Jun 1, 2023

Hi, @zhimingwang36
This PR adds type conversions including bf16 in imf headers, does it meet SYCLomatic requirements?

@jinge90 jinge90 temporarily deployed to aws June 1, 2023 02:18 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws June 1, 2023 02:58 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel removed their request for review June 1, 2023 15:24
@aelovikov-intel
Copy link
Contributor

I don't think I have enough expertise to review this...

@jinge90 jinge90 requested a review from zettai-reido June 2, 2023 00:56
@jinge90
Copy link
Contributor Author

jinge90 commented Jun 2, 2023

Hi, @akolesov-intel
This PR aims type conversion utils to sycl_ext_intel_math_hpp, the function names align with CUDA except that we don't have "__" prefix. Could you take a look?
Thanks very much.

Copy link

@akolesov-nv akolesov-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Thank you for taking care!

Copy link
Contributor

@tangjj11 tangjj11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinge90 jinge90 temporarily deployed to aws August 8, 2023 08:07 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws August 8, 2023 12:12 — with GitHub Actions Inactive
@jinge90 jinge90 requested a review from steffenlarsen August 9, 2023 05:59
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jinge90 jinge90 requested a review from a team August 9, 2023 22:01
@jinge90
Copy link
Contributor Author

jinge90 commented Aug 9, 2023

Hi, @intel/llvm-gatekeepers
Could you help review and merge this patch?
Thanks very much.

@steffenlarsen steffenlarsen merged commit 3506325 into intel:sycl Aug 10, 2023
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
This PR adds C++ wrappers in intel math header for type conversion
functions provided in SYCL libdevice.
The function names align with CUDA correspondence but we don't use "__"
prefix in function name.
For example, CUDA __double2float_ru maps to
sycl::ext::intel::math::double2float_ru.

---------

Signed-off-by: jinge90 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants