[Driver][NFC] cleanup unused -fsycl-link FPGA bundling settings #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing -fsycl-link -fintelfpga, there is no bundling step that occurs which uses the FPGA type specific settings (aocr, aocx, aoco). If a bundling step does occur (with -c), it is only for the specific device compile and does not include the AOT step. These settings were part of an earlier implementation that considered using a bundled binary instead of an archive to store the aocx/aocr generated bits Signed-off-by: Michael D Toguchi <[email protected]>
AGindinson
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing -fsycl-link -fintelfpga, there is no bundling step that occurs
which uses the FPGA type specific settings (aocr, aocx, aoco). If a bundling
step does occur (with -c), it is only for the specific device compile and does
not include the AOT step.
These settings were part of an earlier implementation that considered using
a bundled binary instead of an archive to store the aocx/aocr generated bits
Signed-off-by: Michael D Toguchi [email protected]