[SYCL][Pulldown] Fix llvm-spirv pulldown #9505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
|
Is it something we will need to revert later? Or is it something we need to upstream? In any case, we should submit an issue about those follow-ups (there are already issues in intel/llvm about some patches which were reverted from the translator) |
|
@AlexeySachkov For the builtin-functions one, I already made an internal tracker and will send it to you. For the buffer type one, it's expected because we reverted the upstream entry pointers wrapper stuff here. That document already mentions that change being reverted but it doesn't a list of affected tests. so I don't think I need to add anything. |
AlexeySachkov
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the builtin-functions one is a real issue but it was introduced before just exposed by this test, i can reproduce it in current sycl branch HEAD, i will make an internal tracker
second one is expected because of entry point wrapper thing reverted here
@kchusha should be safe to pull this now