[SYCL] Check if PluginInitializeFunction is NULL before accessing it. #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Garima Gupta <[email protected]>
| @@ -79,6 +79,9 @@ bool bindPlugin(void *Library) { | |||
|
|
|||
| decltype(::piPluginInit) *PluginInitializeFunction = (decltype( | |||
| &::piPluginInit))(getOsLibraryFuncAddress(Library, "piPluginInit")); | |||
| if (PluginInitializeFunction == nullptr) | |||
| return false; | |||
There was a problem hiding this comment.
What do you think about returning some error code instead of just boolean from this function? By doing so, you can report better messages to the user (which might be helpful during debugging).
Right now I see at least two possible breakage points here:
- failed to get
piPluginInitaddress, i.e.PluginIintializeFunction == nullptr
PluginInitializeFunctionreturned non-success error code, i.e.err != PI_SUCCESS
P.S. there is even TODO for this at line 92
There was a problem hiding this comment.
You are right. But this is needed at multiple places.
Whole PI functionality currently is not debugging friendly.
Is it ok if it is taken as a separate patch? @smaslov-intel and @romanovvlad have been suggesting a similar change.
|
@smaslov-intel please review. |
romanovvlad
approved these changes
Dec 24, 2019
smaslov-intel
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Garima Gupta [email protected]