[SYCL] Fix getting host objects for impl objects #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
reviewed
Dec 24, 2019
Impl fields in context_impl and program_impl are initialized with nullptr for host opbjects. That caused segfault on accessing them. Create host objects on access time. Signed-off-by: Vladimir Lazarev <[email protected]>
vladimirlaz
force-pushed
the
private/vlazarev/crash_host
branch
from
49bbda9 to
174787b
Compare
romanovvlad
approved these changes
Dec 25, 2019
keryell
reviewed
Dec 26, 2019
| @@ -324,6 +324,8 @@ class program_impl { | |||
| } | |||
|
|
|||
| context get_context() const { | |||
| if (is_host()) | |||
| return context(); | |||
| @@ -104,6 +104,8 @@ cl_uint context_impl::get_info<info::context::reference_count>() const { | |||
| this->getHandleRef()); | |||
| } | |||
| template <> platform context_impl::get_info<info::context::platform>() const { | |||
| if (is_host()) | |||
| return platform(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vladimir Lazarev [email protected]