Skip to content

[Matrix][tests]Add tests for element wise ops on float type #9679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2023
Merged

[Matrix][tests]Add tests for element wise ops on float type #9679

merged 3 commits into from
Jul 19, 2023

Conversation

dkhaldi
Copy link
Contributor

@dkhaldi dkhaldi commented May 31, 2023

No description provided.

@dkhaldi dkhaldi temporarily deployed to aws May 31, 2023 19:57 — with GitHub Actions Inactive
@dkhaldi dkhaldi temporarily deployed to aws May 31, 2023 20:38 — with GitHub Actions Inactive
YuriPlyakhin
YuriPlyakhin reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code is identical to element_wise_all_ops_bf16_impl.hpp.
I suggest changing element_wise_all_ops_bf16_impl.hpp to support float and matrix C by utilizing template parameters. so that we would have one element_wise_all_ops_impl.hpp supporting all necessary types and matrix A, B and C if needed.
Otherwise it is more and more difficult to maintain all these duplicated codes.

@dkhaldi dkhaldi temporarily deployed to aws June 8, 2023 18:46 — with GitHub Actions Inactive
@dkhaldi dkhaldi temporarily deployed to aws June 8, 2023 19:34 — with GitHub Actions Inactive
YuriPlyakhin
YuriPlyakhin reviewed Jun 8, 2023
View reviewed changes
@dkhaldi dkhaldi temporarily deployed to aws June 9, 2023 18:35 — with GitHub Actions Inactive
@dkhaldi dkhaldi temporarily deployed to aws June 9, 2023 19:34 — with GitHub Actions Inactive
@dkhaldi dkhaldi temporarily deployed to aws June 12, 2023 14:04 — with GitHub Actions Inactive
@dkhaldi
Copy link
Contributor Author

dkhaldi commented Jun 13, 2023

@steffenlarsen, can you please help merge?
The fails should not be related to this patch.

@dm-vodopyanov
Copy link
Contributor

dm-vodopyanov commented Jun 13, 2023 •
edited
Loading

@steffenlarsen, can you please help merge? The fails should not be related to this patch.

It is better to re-run the checks as they didn't start at all:

Error: Unable to find an artifact with the name: sycl_linux_default

According to https://github.com/intel/llvm/blob/sycl/CONTRIBUTING.md#merge, please, ping @intel/llvm-gatekeepers team to merge the PR when it's approved by code owners.

@dkhaldi dkhaldi temporarily deployed to aws June 13, 2023 16:33 — with GitHub Actions Inactive
@dkhaldi dkhaldi temporarily deployed to aws June 13, 2023 19:19 — with GitHub Actions Inactive
@dkhaldi dkhaldi temporarily deployed to aws June 13, 2023 20:30 — with GitHub Actions Inactive
@dm-vodopyanov
Copy link
Contributor

All failures are unrelated to this patch.

@dm-vodopyanov dm-vodopyanov merged commit ffeecb7 into intel:sycl Jul 19, 2023
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
@dkhaldi @mdtoguchi
[SYCL][Matrix] Add tests for element wise ops on float type (intel#9679)
f0d0a23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriPlyakhin YuriPlyakhin YuriPlyakhin approved these changes

@yubingex007-a11y yubingex007-a11y Awaiting requested review from yubingex007-a11y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkhaldi @dm-vodopyanov @YuriPlyakhin