-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL][Driver] Emit an error when PCH is triggered in SYCL mode. #9689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I think about this a little more, the use model for creating a PCH file is more implied and may catch folks off guard. Let's say a person creates a PCH file with a non-SYCL compilation with clang++ my_header.h
. Later on, they want to pull in that header with an -fsycl
compile like clang++ -fsycl -include my_header.h file.cpp
. I don't see this as being invalid. So when we go into consumption of PCH files with -fsycl
we should think about this case.
Co-authored-by: premanandrao <[email protected]>
@intel/llvm-gatekeepers Hi, this is ready to be merged. |
@intel/llvm-gatekeepers ping. |
Emit an error if PCH(Pre-Compiled Header) file generation is forced in -fsycl mode.