Skip to content

[SYCL][Driver] Emit an error when PCH is triggered in SYCL mode. #9689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 15, 2023

Conversation

srividya-sundaram
Copy link
Contributor

@srividya-sundaram srividya-sundaram commented Jun 1, 2023

Emit an error if PCH(Pre-Compiled Header) file generation is forced in -fsycl mode.

@srividya-sundaram srividya-sundaram temporarily deployed to aws June 1, 2023 05:38 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 1, 2023 06:21 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 5, 2023 22:39 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 5, 2023 23:21 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 6, 2023 03:50 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 6, 2023 04:51 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 7, 2023 23:42 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram marked this pull request as ready for review June 7, 2023 23:54
@srividya-sundaram srividya-sundaram requested review from a team as code owners June 7, 2023 23:54
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 8, 2023 00:23 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 8, 2023 04:01 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 8, 2023 04:43 — with GitHub Actions Inactive
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I think about this a little more, the use model for creating a PCH file is more implied and may catch folks off guard. Let's say a person creates a PCH file with a non-SYCL compilation with clang++ my_header.h. Later on, they want to pull in that header with an -fsycl compile like clang++ -fsycl -include my_header.h file.cpp. I don't see this as being invalid. So when we go into consumption of PCH files with -fsycl we should think about this case.

@srividya-sundaram srividya-sundaram temporarily deployed to aws June 9, 2023 19:52 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 9, 2023 20:57 — with GitHub Actions Inactive
@srividya-sundaram
Copy link
Contributor Author

@intel/llvm-gatekeepers Hi, this is ready to be merged.

@srividya-sundaram srividya-sundaram temporarily deployed to aws June 14, 2023 03:54 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 14, 2023 17:01 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws June 14, 2023 18:43 — with GitHub Actions Inactive
@srividya-sundaram
Copy link
Contributor Author

@intel/llvm-gatekeepers ping.
The failures in SYCL Pre Commit / Linux / [AWS] CUDA LLVM Test Suite (pull_request_target) is unrelated to the changes in this PR.

@dm-vodopyanov dm-vodopyanov changed the title [Driver] Emit an error when PCH is triggered in SYCL mode. [SYCL][Driver] Emit an error when PCH is triggered in SYCL mode. Jun 15, 2023
@dm-vodopyanov dm-vodopyanov merged commit 0624465 into intel:sycl Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants