[SYCL] Allow group algorithms to accept a function object with an explicit type #9784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x12CC
reviewed
Jun 8, 2023
| using type = F<T>; | ||
| }; | ||
|
|
||
| template <template <typename> typename F> struct get_scalar_binary_op<F<void>> { |
There was a problem hiding this comment.
Why is this template specialization needed?
There was a problem hiding this comment.
To handle the function types without an explicit argument, e.g. in a case like reduce_over_group(g, int2{}, sycl::plus<>()), we will be instantiating get_scalar_binary_op with sycl::plus<void> (= sycl::plus<>) , which does not match the other partial specialization, so we need this to compile correctly.
0x12CC
approved these changes
Jun 8, 2023
|
@intel/sycl-language-enabling-triage: FYI @sergey-semenov, @intel/llvm-reviewers-runtime, could you please take a look? |
sergey-semenov
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes unnecessary special cases for half in the static assertions of the group algorithms (and adds corresponding tests for them) and refactors the
reduce_sycl2020.cpp,inclusive_scan_sycl2020.cpp, andexclusive_scan_sycl2020.cpptests a bit.