Skip to content

[SYCL][DOC] Add sycl_ext_oneapi_work_group_local #9799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Pennycook
Copy link
Contributor

Introduces support for work-group local allocations at program and function scope, lifting some of the restrictions of sycl_ext_oneapi_group_local_memory.

Introduces support for work-group local allocations at program and function
scope, lifting some of the restrictions of sycl_ext_oneapi_group_local_memory.

Signed-off-by: John Pennycook <[email protected]>
@Pennycook Pennycook added the spec extension All issues/PRs related to extensions specifications label Jun 8, 2023
@Pennycook Pennycook requested a review from a team as a code owner June 8, 2023 17:07
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this generally looks good, but a couple of comments below.

- Use sizeof(int) to highlight that the unit is bytes.
- Use M to highlight that runtime values are supported.
Co-authored-by: Greg Lueck <[email protected]>
@Pennycook
Copy link
Contributor Author

@intel/llvm-gatekeepers: This is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec extension All issues/PRs related to extensions specifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants