[SYCL] Make host device and host platform always available, even when forcin… #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a device type with SYCL_DEVICE_TYPE Signed-off-by: James Brodman <[email protected]>
|
Please add LIT test following example in the PR description. |
vladimirlaz
reviewed
Jan 9, 2020
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
Added a test for host device and another for host platform. |
vladimirlaz
reviewed
Jan 10, 2020
vladimirlaz
reviewed
Jan 10, 2020
Signed-off-by: James Brodman <[email protected]>
vladimirlaz
previously approved these changes
Jan 13, 2020
KarachunIvan
previously approved these changes
Jan 13, 2020
bader
reviewed
Jan 13, 2020
romanovvlad
reviewed
Jan 13, 2020
| if (plt.is_host()) { | ||
| vector_class<device> host_device( | ||
| plt.get_devices(info::device_type::host)); | ||
| if (!host_device.empty()) |
There was a problem hiding this comment.
Isn't this if redundant? I think insert will correctly handle case when begin iterator == end iterator.
There was a problem hiding this comment.
No - get_devices is supposed to only return devices of the passed type, hence the special casing for host devices.
Signed-off-by: James Brodman <[email protected]>
jbrodman
dismissed stale reviews from KarachunIvan and vladimirlaz
via
fd977d2
👍 |
vladimirlaz
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g a device type with SYCL_DEVICE_TYPE
The current behavior violates the SYCL Specification. The host device/platform should always be available.
int main() {
device myHost(host_selector{});
return 0;
}
That fails when run with SYCL_DEVICE_TYPE=CPU/GPU/ACC and it shouldn't.
Signed-off-by: James Brodman [email protected]