Skip to content

[SYCL] Revert recent copy requirements temporarily #9970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sycl/include/sycl/handler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -2289,8 +2289,8 @@ class __SYCL_EXPORT handler {
"Invalid accessor target for the copy method.");
static_assert(isValidModeForDestinationAccessor(AccessMode),
"Invalid accessor mode for the copy method.");
static_assert(is_device_copyable<T_Src>::value,
"Pattern must be device copyable");
// TODO: Add static_assert with is_device_copyable when vec is
// device-copyable.
// Make sure data shared_ptr points to is not released until we finish
// work with it.
CGData.MSharedPtrStorage.push_back(Src);
Expand Down Expand Up @@ -2360,8 +2360,8 @@ class __SYCL_EXPORT handler {
"Invalid accessor target for the copy method.");
static_assert(isValidModeForDestinationAccessor(AccessMode),
"Invalid accessor mode for the copy method.");
static_assert(is_device_copyable<T_Src>::value,
"Pattern must be device copyable");
// TODO: Add static_assert with is_device_copyable when vec is
// device-copyable.
#ifndef __SYCL_DEVICE_ONLY__
if (MIsHost) {
// TODO: Temporary implementation for host. Should be handled by memory
Expand Down