Skip to content

[SYCL] Non-standard RT namespace removed (#7133) #9972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2023
Merged

[SYCL] Non-standard RT namespace removed (#7133) #9972

merged 4 commits into from
Jun 22, 2023

Conversation

marcin-smuklerz-mobica
Copy link
Contributor

Continuation of previous partial removal (#9837)

@marcin-smuklerz-mobica
[SYCL] Non-standard RT namespace removed (intel#7133)
1578851 
Continuation of previous partial removal (intel#9837)
sommerlukas
sommerlukas approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@sommerlukas sommerlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed jit_compiler.cpp owned by our team.

steffenlarsen
steffenlarsen approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Could you please run clang-format on your changes?

@marcin-smuklerz-mobica marcin-smuklerz-mobica temporarily deployed to aws June 21, 2023 08:44 — with GitHub Actions Inactive
@marcin-smuklerz-mobica marcin-smuklerz-mobica temporarily deployed to aws June 21, 2023 09:24 — with GitHub Actions Inactive
@steffenlarsen
Copy link
Contributor

ESIMD failure don't look related, but you may need to push a merge commit to make them disappear.

@marcin-smuklerz-mobica marcin-smuklerz-mobica temporarily deployed to aws June 21, 2023 11:14 — with GitHub Actions Inactive
@marcin-smuklerz-mobica marcin-smuklerz-mobica temporarily deployed to aws June 21, 2023 11:15 — with GitHub Actions Inactive
@marcin-smuklerz-mobica marcin-smuklerz-mobica temporarily deployed to aws June 21, 2023 12:30 — with GitHub Actions Inactive
@marcin-smuklerz-mobica marcin-smuklerz-mobica temporarily deployed to aws June 21, 2023 12:36 — with GitHub Actions Inactive
@marcin-smuklerz-mobica marcin-smuklerz-mobica temporarily deployed to aws June 22, 2023 05:47 — with GitHub Actions Inactive
@marcin-smuklerz-mobica marcin-smuklerz-mobica temporarily deployed to aws June 22, 2023 06:24 — with GitHub Actions Inactive
@marcin-smuklerz-mobica marcin-smuklerz-mobica temporarily deployed to aws June 22, 2023 06:57 — with GitHub Actions Inactive
@marcin-smuklerz-mobica marcin-smuklerz-mobica temporarily deployed to aws June 22, 2023 07:35 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen merged commit fd636ef into intel:sycl Jun 22, 2023
@marcin-smuklerz-mobica marcin-smuklerz-mobica deleted the RT_namespace_continuation branch June 22, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sommerlukas sommerlukas sommerlukas approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@victor-eds victor-eds Awaiting requested review from victor-eds

@Naghasan Naghasan Awaiting requested review from Naghasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcin-smuklerz-mobica @steffenlarsen @sommerlukas