Skip to content

[LIBCLC] Use default compilation DB for ClangTool run #9974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2023
Merged

[LIBCLC] Use default compilation DB for ClangTool run #9974

merged 1 commit into from
Jun 20, 2023

Conversation

jchlanda
Copy link
Contributor

Since 94f7c96 landed the -fno-lifetime-dse option is added to the compilation database, if using non-llvm based toolchains, this option is not compatible with clang and as tools invocation in libclc does not relay on the content of the DB, use the default, empty one.

Also fix deprecated makeArrayRef warning.

cc: abagusetty

@jchlanda jchlanda requested review from ldrumm and AlexeySachkov June 19, 2023 13:03
@jchlanda jchlanda requested a review from a team as a code owner June 19, 2023 13:03
@jchlanda jchlanda requested a review from steffenlarsen June 19, 2023 13:03
@jchlanda jchlanda mentioned this pull request Jun 19, 2023
Closed
steffenlarsen
steffenlarsen approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jchlanda jchlanda temporarily deployed to aws June 19, 2023 13:20 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws June 19, 2023 19:25 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws June 20, 2023 05:33 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws June 20, 2023 06:11 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov merged commit d8f6a6a into intel:sycl Jun 20, 2023
@ldrumm
Copy link
Contributor

ldrumm commented Jun 20, 2023

sorry, missed this.
But LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@ldrumm ldrumm Awaiting requested review from ldrumm

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jchlanda @ldrumm @steffenlarsen @AlexeySachkov