Skip to content

[SYCL] Update Level Zero Loader to v1.11.0 #9979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

dm-vodopyanov
Copy link
Contributor

@dm-vodopyanov dm-vodopyanov commented Jun 19, 2023

This patch updates Level Zero Loader to version v1.11.0 because
the previous version does not support implementation of
oneapi-src/level-zero-spec#23 Level Zero extension, required for
implementing sycl_ext_oneapi_device_architecture on host

Addresses #9843 (comment)

This patch updates Level Zero Loader to version v1.11.0 because the
previous version does not support implementation of oneapi-src/level-zero-spec#23
Level Zero extension, required for implementing
sycl_ext_oneapi_device_architecture on host

Addresses intel#9843 (comment)
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws June 19, 2023 19:28 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws June 19, 2023 20:08 — with GitHub Actions Inactive
@dm-vodopyanov
Copy link
Contributor Author

CUDA test failed, unrelated to this patch:

Failed Tests (1):
  SYCL :: Basic/barrier_order.cpp

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen steffenlarsen merged commit f9d285e into intel:sycl Jun 20, 2023
@dm-vodopyanov
Copy link
Contributor Author

dm-vodopyanov commented Jun 20, 2023

Failure in post-commit:

https://github.com/intel/llvm/actions/runs/5318954472/jobs/9630923879#step:7:8914

Build failed because Level Zero loader has warnings. These warnings treated as errors.

@jandres742 does the next release - v1.12.0 - has the same warnings? If yes, they block implementation of sycl_ext_oneapi_device_architecture feature, and the fix in Level Zero loader is required. If there are no warnings in v1.12.0, we can update to v1.12.0.

@jandres742
Copy link
Contributor

thanks @dm-vodopyanov

@bmyates , @nrspruit : please see the errors we are getting from the loader. I think they remain still on latest version, correct? If so, could they be fixed and made available in a new version of the loader released quick?

/__w/llvm/llvm/build/_deps/level-zero-loader-src/source/layers/validation/common/ze_entry_points.h:18:7: error: 'validation_layer::ZEValidationEntryPoints' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
   18 | class ZEValidationEntryPoints {
      |       ^

@dm-vodopyanov
Copy link
Contributor Author

dm-vodopyanov commented Jun 20, 2023

Just in case, there are more warnings, not just the one above. @bmyates @nrspruit, please check the full logs on the link above to see all errors

@bmyates
Copy link
Contributor

bmyates commented Jun 20, 2023

@dm-vodopyanov SYCL is enabling many more warnings in L0 loader build beyond what L0 loader CI uses. Fastest way to fix this issue would be for SYCL to imply ignore this specific warning. SYCL is already doing this for a few other warnings here:

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-but-set-variable")

Please also file a JIRA in GSD project and we will fix root cause in loader.

dm-vodopyanov added a commit to dm-vodopyanov/llvm that referenced this pull request Jun 20, 2023
@dm-vodopyanov
Copy link
Contributor Author

@jandres742 @bmyates thanks for quick reply! Created PR with a w/a, and created an issue.

aelovikov-intel pushed a commit that referenced this pull request Jun 20, 2023
dm-vodopyanov added a commit that referenced this pull request Jun 30, 2023
…l Zero and OpenCL (#9843)

This patch introduces new host API for
sycl_ext_oneapi_device_architecture extension and implements it,
currently only for Level Zero and OpenCL

Depends on 

- oneapi-src/unified-runtime#573
- #9873
- #9979
- #10054
veselypeta pushed a commit to veselypeta/llvm that referenced this pull request Sep 21, 2023
…l Zero and OpenCL (intel#9843)

This patch introduces new host API for
sycl_ext_oneapi_device_architecture extension and implements it,
currently only for Level Zero and OpenCL

Depends on 

- oneapi-src/unified-runtime#573
- intel#9873
- intel#9979
- intel#10054
omarahmed1111 pushed a commit to omarahmed1111/unified-runtime that referenced this pull request Oct 23, 2023
…l Zero and OpenCL (#9843)

This patch introduces new host API for
sycl_ext_oneapi_device_architecture extension and implements it,
currently only for Level Zero and OpenCL

Depends on 

- oneapi-src#573
- intel/llvm#9873
- intel/llvm#9979
- intel/llvm#10054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants