[SYCL][Driver] Windows output with -fsycl-link not generating expecte… #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGindinson
reviewed
Jan 13, 2020
When specifying output options with -fsycl-link -fintelfpga on Windows, the named output is not used. This is due to the output type for -fsycl-link being an archive type not being recognized when generating output file names. Also address a problem seen where use of /Fo was using that name for the intermediate unbundling step. Signed-off-by: Michael D Toguchi <[email protected]>
mdtoguchi
force-pushed
the
private/mdtoguchi/fsycl-link-win-output
branch
from
83e1506 to
b3484c7
Compare
AGindinson
reviewed
Jan 14, 2020
When the output file is specified by the user, that output file should not be used for the intermediate unbundling step. Signed-off-by: Michael D Toguchi <[email protected]>
Signed-off-by: Michael D Toguchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d output
When specifying output options with -fsycl-link -fintelfpga on Windows, the
named output is not used. This is due to the output type for -fsycl-link
being an archive type not being recognized when generating output file names.
Also address a problem seen where use of /Fo was using that name for the
intermediate unbundling step.
Signed-off-by: Michael D Toguchi [email protected]