[SYCL][Graph] L0 Backend support for SYCL Graphs (2/4) #9992

Bensuo · 2023-06-20T17:25:56Z

Level Zero Backend Support for SYCL Graphs

This is the second patch of a series that adds support for an experimental command graph extension

A snapshot of the complete work can be seen in draft PR #9375 which has support all the specification defined ways of
adding nodes and edges to the graph, including both Explicit and Record & Replay graph construction. The two types of nodes currently implemented are kernel execution and memcpy commands.

See https://github.com/reble/llvm#implementation-status for the status of our total work.

Scope

This second patch focuses on the required PI/UR support for the experimental command-buffer feature in the Level Zero adapter:

PI stubs for all adapters to enable compilation, no functionality.
Command-buffer implementation for the Level Zero UR adapter.
Stubs for the CUDA UR adapter to enable compilation, no functionality.

Following Split PRs

Future follow-up PRs with the remainder of our work on the extension will include:

Hooking up backend to graphs runtime, bugfixes and other feature additions, will add symbols but not break the ABI. (3/4)
Add end-to-end tests for SYCL Graph extension. (4/4)
NFC changes - Design doc and codeowner update.

Authors

Co-authored-by: Pablo Reble [email protected]
Co-authored-by: Julian Miller [email protected]
Co-authored-by: Ben Tracy [email protected]
Co-authored-by: Ewan Crawford [email protected]
Co-authored-by: Maxime France-Pillois [email protected]

- Squashed commit of command-buffer UR changes - Level Zero implementation - Stubs for all other adapters

bader

I didn't go deep into the code, so just some style comments.

sycl/include/sycl/detail/pi.h

sycl/plugins/hip/pi_hip.cpp

sycl/plugins/unified_runtime/ur/adapters/cuda/command_buffer.hpp

sycl/plugins/unified_runtime/ur/adapters/cuda/command_buffer.cpp

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_command_buffer.cpp

sycl/include/sycl/detail/pi.h

sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_event.cpp

Pulls in changes from #238 which requires bumping the UR commit to oneapi-src/unified-runtime#644 Co-authored-by: Maxime France-Pillois <[email protected]>

EwanC · 2023-06-30T13:05:57Z

Hi @bso-intel, would you be able to review this on behalf of @intel/llvm-reviewers-runtime.

Could someone from @intel/dpcpp-esimd-reviewers please also review this PR.

sarnex

esimd lgtm

steffenlarsen

Small comments, but otherwise LGTM!

sycl/include/sycl/detail/pi.def

sycl/plugins/opencl/pi_opencl.cpp

Define a return error code in PI opencl stubs

steffenlarsen

Failed Tests (1):
SYCL :: ESIMD/accessor_local.cpp - Reported in #10138 and has since been disabled.

Fixes error found in [post-commit CI](https://github.com/intel/llvm/actions/runs/5454766342/jobs/9925392005) after the merge of intel#9992 ``` /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5635:24: error: unused parameter 'sync_point' [-Werror,-Wunused-parameter] 5635 | pi_ext_sync_point *sync_point) { | ^ /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5691:12: error: unused parameter 'dst_row_pitch' [-Werror,-Wunused-parameter] 5691 | size_t dst_row_pitch, size_t dst_slice_pitch, | ^ /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5691:34: error: unused parameter 'dst_slice_pitch' [-Werror,-Wunused-parameter] 5691 | size_t dst_row_pitch, size_t dst_slice_pitch, | ^ 3 errors generated. ```

Fixes error found in [post-commit CI](https://github.com/intel/llvm/actions/runs/5454766342/jobs/9925392005) after the merge of #9992 ``` /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5635:24: error: unused parameter 'sync_point' [-Werror,-Wunused-parameter] 5635 | pi_ext_sync_point *sync_point) { | ^ /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5691:12: error: unused parameter 'dst_row_pitch' [-Werror,-Wunused-parameter] 5691 | size_t dst_row_pitch, size_t dst_slice_pitch, | ^ /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5691:34: error: unused parameter 'dst_slice_pitch' [-Werror,-Wunused-parameter] 5691 | size_t dst_row_pitch, size_t dst_slice_pitch, | ^ 3 errors generated. ```

…hs (3/4) (#10033) # Backend integration and feature additions for SYCL Graphs This is the third patch of a series that adds support for an [experimental command graph extension](#5626) A snapshot of the complete work can be seen in draft PR #9375 which has support all the specification defined ways of adding nodes and edges to the graph, including both Explicit and Record & Replay graph construction. The two types of nodes currently implemented are kernel execution and memcpy commands. See https://github.com/reble/llvm#implementation-status for the status of our total work. ## Scope This third patch focuses on integrating the graphs runtime with the backend support added in #9992 as well as any remaining runtime features and bug fixes, and should include no ABI-breaking changes: * Graphs runtime changes to use PI/UR command-buffers. * Various improvements to the Graphs runtime classes. * New memory manager methods for appending copies to a command-buffer. * Changes to the Scheduler and related CG classes to enable Graphs. * Device info query for command-graph support. * Minor changes to some runtime classes to enable Graphs. ## Following Split PRs Future follow-up PRs with the remainder of our work on the extension will include: * Add end-to-end tests for SYCL Graph extension. (4/4) * NFC changes - Design doc and codeowner update. ## Authors Co-authored-by: Pablo Reble <[email protected]> Co-authored-by: Julian Miller <[email protected]> Co-authored-by: Ben Tracy <[email protected]> Co-authored-by: Ewan Crawford <[email protected]> Co-authored-by: Maxime France-Pillois <[email protected]>

# Level Zero Backend Support for SYCL Graphs This is the second patch of a series that adds support for an [experimental command graph extension](intel#5626) A snapshot of the complete work can be seen in draft PR intel#9375 which has support all the specification defined ways of adding nodes and edges to the graph, including both Explicit and Record & Replay graph construction. The two types of nodes currently implemented are kernel execution and memcpy commands. See https://github.com/reble/llvm#implementation-status for the status of our total work. ## Scope This second patch focuses on the required PI/UR support for the experimental command-buffer feature in the Level Zero adapter: * PI stubs for all adapters to enable compilation, no functionality. * Command-buffer implementation for the Level Zero UR adapter. * Stubs for the CUDA UR adapter to enable compilation, no functionality. ## Following Split PRs Future follow-up PRs with the remainder of our work on the extension will include: * Hooking up backend to graphs runtime, bugfixes and other feature additions, will add symbols but not break the ABI. (3/4) * Add end-to-end tests for SYCL Graph extension. (4/4) * NFC changes - Design doc and codeowner update. ## Authors Co-authored-by: Pablo Reble <[email protected]> Co-authored-by: Julian Miller <[email protected]> Co-authored-by: Ben Tracy <[email protected]> Co-authored-by: Ewan Crawford <[email protected]> Co-authored-by: Maxime France-Pillois <[email protected]> --------- Co-authored-by: Ewan Crawford <[email protected]> Co-authored-by: Maxime France-Pillois <[email protected]>

…hs (3/4) (intel#10033) # Backend integration and feature additions for SYCL Graphs This is the third patch of a series that adds support for an [experimental command graph extension](intel#5626) A snapshot of the complete work can be seen in draft PR intel#9375 which has support all the specification defined ways of adding nodes and edges to the graph, including both Explicit and Record & Replay graph construction. The two types of nodes currently implemented are kernel execution and memcpy commands. See https://github.com/reble/llvm#implementation-status for the status of our total work. ## Scope This third patch focuses on integrating the graphs runtime with the backend support added in intel#9992 as well as any remaining runtime features and bug fixes, and should include no ABI-breaking changes: * Graphs runtime changes to use PI/UR command-buffers. * Various improvements to the Graphs runtime classes. * New memory manager methods for appending copies to a command-buffer. * Changes to the Scheduler and related CG classes to enable Graphs. * Device info query for command-graph support. * Minor changes to some runtime classes to enable Graphs. ## Following Split PRs Future follow-up PRs with the remainder of our work on the extension will include: * Add end-to-end tests for SYCL Graph extension. (4/4) * NFC changes - Design doc and codeowner update. ## Authors Co-authored-by: Pablo Reble <[email protected]> Co-authored-by: Julian Miller <[email protected]> Co-authored-by: Ben Tracy <[email protected]> Co-authored-by: Ewan Crawford <[email protected]> Co-authored-by: Maxime France-Pillois <[email protected]>

# Level Zero Backend Support for SYCL Graphs This is the second patch of a series that adds support for an [experimental command graph extension](intel#5626) A snapshot of the complete work can be seen in draft PR intel#9375 which has support all the specification defined ways of adding nodes and edges to the graph, including both Explicit and Record & Replay graph construction. The two types of nodes currently implemented are kernel execution and memcpy commands. See https://github.com/reble/llvm#implementation-status for the status of our total work. ## Scope This second patch focuses on the required PI/UR support for the experimental command-buffer feature in the Level Zero adapter: * PI stubs for all adapters to enable compilation, no functionality. * Command-buffer implementation for the Level Zero UR adapter. * Stubs for the CUDA UR adapter to enable compilation, no functionality. ## Following Split PRs Future follow-up PRs with the remainder of our work on the extension will include: * Hooking up backend to graphs runtime, bugfixes and other feature additions, will add symbols but not break the ABI. (3/4) * Add end-to-end tests for SYCL Graph extension. (4/4) * NFC changes - Design doc and codeowner update. ## Authors Co-authored-by: Pablo Reble <[email protected]> Co-authored-by: Julian Miller <[email protected]> Co-authored-by: Ben Tracy <[email protected]> Co-authored-by: Ewan Crawford <[email protected]> Co-authored-by: Maxime France-Pillois <[email protected]> --------- Co-authored-by: Ewan Crawford <[email protected]> Co-authored-by: Maxime France-Pillois <[email protected]>

Fixes error found in [post-commit CI](https://github.com/intel/llvm/actions/runs/5454766342/jobs/9925392005) after the merge of intel#9992 ``` /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5635:24: error: unused parameter 'sync_point' [-Werror,-Wunused-parameter] 5635 | pi_ext_sync_point *sync_point) { | ^ /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5691:12: error: unused parameter 'dst_row_pitch' [-Werror,-Wunused-parameter] 5691 | size_t dst_row_pitch, size_t dst_slice_pitch, | ^ /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5691:34: error: unused parameter 'dst_slice_pitch' [-Werror,-Wunused-parameter] 5691 | size_t dst_row_pitch, size_t dst_slice_pitch, | ^ 3 errors generated. ```

Fixes error found in [post-commit CI](https://github.com/intel/llvm/actions/runs/5454766342/jobs/9925392005) after the merge of intel/llvm#9992 ``` /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5635:24: error: unused parameter 'sync_point' [-Werror,-Wunused-parameter] 5635 | pi_ext_sync_point *sync_point) { | ^ /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5691:12: error: unused parameter 'dst_row_pitch' [-Werror,-Wunused-parameter] 5691 | size_t dst_row_pitch, size_t dst_slice_pitch, | ^ /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:5691:34: error: unused parameter 'dst_slice_pitch' [-Werror,-Wunused-parameter] 5691 | size_t dst_row_pitch, size_t dst_slice_pitch, | ^ 3 errors generated. ```

Bensuo temporarily deployed to aws June 21, 2023 10:00 — with GitHub Actions Inactive

Bensuo temporarily deployed to aws June 21, 2023 10:43 — with GitHub Actions Inactive

[SYCL][Graphs] Squashed Graphs UR changes

028657a

- Squashed commit of command-buffer UR changes - Level Zero implementation - Stubs for all other adapters

Bensuo force-pushed the sycl-graph-patch-2 branch from 00e8f74 to 028657a Compare June 21, 2023 11:46

Bensuo temporarily deployed to aws June 21, 2023 12:10 — with GitHub Actions Inactive

Merge remote-tracking branch 'origin/sycl' into sycl-graph-patch-2

6dc1973

Bensuo temporarily deployed to aws June 21, 2023 13:09 — with GitHub Actions Inactive

Bensuo temporarily deployed to aws June 21, 2023 13:42 — with GitHub Actions Inactive

Bensuo temporarily deployed to aws June 21, 2023 14:19 — with GitHub Actions Inactive

Bensuo marked this pull request as ready for review June 21, 2023 16:20

Bensuo requested review from a team as code owners June 21, 2023 16:20

Bensuo requested review from npmiller and bso-intel June 21, 2023 16:20

Merge remote-tracking branch 'origin/sycl' into sycl-graph-patch-2

6653b33

Bensuo temporarily deployed to aws June 22, 2023 11:27 — with GitHub Actions Inactive

Bensuo temporarily deployed to aws June 22, 2023 12:07 — with GitHub Actions Inactive

Bensuo changed the title ~~[SYCL][Graph] Backend support for SYCL Graphs (2/4)~~ [SYCL][Graph] L0 Backend support for SYCL Graphs (2/4) Jun 22, 2023

Bensuo mentioned this pull request Jun 22, 2023

[SYCL][Graph] Backend integration and feature additions for SYCL Graphs (3/4) #10033

Merged

bader reviewed Jun 22, 2023

View reviewed changes

This was referenced Jun 5, 2023

[SYCL][Graph] Adding experimental implementation of SYCL Command Graph extension #9375

Closed

[SYCL][Graph] Support for read and write for 1d and 2d buffers reble/llvm#238

Merged

[SYCL] Formatting changes from code review

b57fe83

EwanC temporarily deployed to aws June 26, 2023 20:05 — with GitHub Actions Inactive

EwanC temporarily deployed to aws June 26, 2023 22:15 — with GitHub Actions Inactive

[SYCL] Support for read and write for 1d and 2d buffers

793bc43

Pulls in changes from #238 which requires bumping the UR commit to oneapi-src/unified-runtime#644 Co-authored-by: Maxime France-Pillois <[email protected]>

EwanC temporarily deployed to aws June 27, 2023 09:26 — with GitHub Actions Inactive

Merge branch 'sycl' into sycl-graph-patch-2

2edefc9

Merge branch 'sycl' into sycl-graph-patch-2

aae0345

EwanC temporarily deployed to aws June 30, 2023 12:51 — with GitHub Actions Inactive

Comment on future optimization

c385466

EwanC temporarily deployed to aws June 30, 2023 14:13 — with GitHub Actions Inactive

sarnex approved these changes Jun 30, 2023

View reviewed changes

EwanC temporarily deployed to aws June 30, 2023 17:00 — with GitHub Actions Inactive

Merge branch 'sycl' into sycl-graph-patch-2

e073549

EwanC temporarily deployed to aws July 3, 2023 08:31 — with GitHub Actions Inactive

EwanC temporarily deployed to aws July 3, 2023 09:53 — with GitHub Actions Inactive

EwanC requested a review from steffenlarsen July 3, 2023 10:14

steffenlarsen approved these changes Jul 3, 2023

View reviewed changes

sycl/include/sycl/detail/pi.def Outdated Show resolved Hide resolved

sycl/plugins/opencl/pi_opencl.cpp Outdated Show resolved Hide resolved

EwanC added 2 commits July 4, 2023 08:39

Merge branch 'sycl' into sycl-graph-patch-2

b70ab4d

Move new entry-points to end of pi.def

9b442e5

Define a return error code in PI opencl stubs

EwanC temporarily deployed to aws July 4, 2023 08:14 — with GitHub Actions Inactive

EwanC temporarily deployed to aws July 4, 2023 08:53 — with GitHub Actions Inactive

steffenlarsen approved these changes Jul 4, 2023

View reviewed changes

steffenlarsen merged commit 96a6050 into intel:sycl Jul 4, 2023

EwanC mentioned this pull request Jul 4, 2023

[SYCL][HIP] Ignore unused PI command-buffer parameters #10192

Merged

Chenyang-L mentioned this pull request Jul 11, 2023

LLVM and SPIRV-LLVM-Translator pulldown (WW25) #10311

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][Graph] L0 Backend support for SYCL Graphs (2/4) #9992

[SYCL][Graph] L0 Backend support for SYCL Graphs (2/4) #9992

Uh oh!

Bensuo commented Jun 20, 2023 •

edited

Loading

Uh oh!

bader left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EwanC commented Jun 30, 2023

Uh oh!

sarnex left a comment •

edited

Loading

Uh oh!

steffenlarsen left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

steffenlarsen left a comment

Uh oh!

Uh oh!

[SYCL][Graph] L0 Backend support for SYCL Graphs (2/4) #9992

[SYCL][Graph] L0 Backend support for SYCL Graphs (2/4) #9992

Uh oh!

Conversation

Bensuo commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Level Zero Backend Support for SYCL Graphs

Scope

Following Split PRs

Authors

Uh oh!

bader left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EwanC commented Jun 30, 2023

Uh oh!

sarnex left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

steffenlarsen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

steffenlarsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bensuo commented Jun 20, 2023 •

edited

Loading

sarnex left a comment •

edited

Loading

steffenlarsen left a comment •

edited

Loading