Skip to content

[mlir] Allow accessing DialectResourceBlobManager::blobMap (cherry-pick) #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

andrey-golubev
Copy link
Contributor

@andrey-golubev andrey-golubev commented Jun 23, 2025

Summary

Add a new API to access all blobs that are stored in the blob manager. The main purpose (as of now) is to allow users of dialect resources to iterate over all blobs, especially when the blobs are no longer used in IR (e.g. the operation that uses the blob is deleted) and thus cannot be easily accessed without manual tracking of keys.

JIRA ticket

  • E-xxxxx

Related PR in NPU Compiler and/or OpenVINO repository with sub-module update

Other related tickets

List tickets for additional work, eg, something was found during review but you agreed to address it in another Jira

  • E-xxxxx

Add a new API to access all blobs that are stored in the blob manager.
The main purpose (as of now) is to allow users of dialect resources to
iterate over all blobs, especially when the blobs are no longer used in
IR (e.g. the operation that uses the blob is deleted) and thus cannot be
easily accessed without manual tracking of keys.
@andrey-golubev andrey-golubev requested a review from a team as a code owner June 23, 2025 09:58
@andrey-golubev
Copy link
Contributor Author

Local testing:

agolubev@irlvmvagolubev:~/npu-plugin-llvm/build$ ninja check-llvm
[691/692] Running the LLVM regression tests
 
Testing Time: 1413.30s
 
Total Discovered Tests: 60818
  Skipped          :    15 (0.02%)
  Unsupported      :  1089 (1.79%)
  Passed           : 59547 (97.91%)
  Expectedly Failed:   167 (0.27%)
 
agolubev@irlvmvagolubev:~/npu-plugin-llvm/build$ ninja check-mlir
[135/136] Running the MLIR regression tests
 
Testing Time: 18.32s
 
Total Discovered Tests: 2903
  Skipped          :    2 (0.07%)
  Unsupported      :  502 (17.29%)
  Passed           : 2398 (82.60%)
  Expectedly Failed:    1 (0.03%)

Given that the change is isolated (unused in MLIR so far), we don't need to run NPU tests.

@andrey-golubev andrey-golubev merged commit 544ee1a into npu/release/19.x Jun 23, 2025
8 checks passed
@andrey-golubev andrey-golubev deleted the agolubev/cherry_pick_blobmap branch June 23, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants