Skip to content

[OpenCL] Add SPV_KHR_integer_dot_product support #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

haonanya
Copy link

This is backporting of https://reviews.llvm.org/D106434

Signed-off-by: haonanya [email protected]

@haonanya haonanya requested review from cdai2, fzou1 and wenju-he January 4, 2022 00:45
Copy link
Contributor

@wenju-he wenju-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changes in clang/lib/Sema/OpenCLBuiltins.td is not in this patch?

@haonanya
Copy link
Author

haonanya commented Jan 4, 2022

why changes in clang/lib/Sema/OpenCLBuiltins.td is not in this patch?

There are big gaps on clang main and release/9.x, it can work when include opencl-c.h currently. And I have added missing tableGen definitions for branch 100, 110 and 120.

@wenju-he
Copy link
Contributor

wenju-he commented Jan 4, 2022

why changes in clang/lib/Sema/OpenCLBuiltins.td is not in this patch?

There are big gaps on clang main and release/9.x, it can work when include opencl-c.h currently. And I have added missing tableGen definitions for branch 100, 110 and 120.

Ok, LGTM, thanks.

@haonanya haonanya merged commit c44dfa4 into intel:ocl-open-90 Jan 4, 2022
@haonanya haonanya deleted the integer_dot_product_90 branch June 16, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants