Exit CMake processing when apply_patches failed #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: haonanya <[email protected]>
wenju-he
approved these changes
Jan 5, 2022
fzou1
reviewed
Jan 5, 2022
haonanya
force-pushed
the
improve_apply_patch
branch
from
5439d32 to
fcc8da1
Compare
fzou1
approved these changes
Jan 5, 2022
Signed-off-by: haonanya <[email protected]>
haonanya
pushed a commit
to haonanya/opencl-clang
that referenced
this pull request
Jan 5, 2022
This backports patches from other branches 1. Check if apply_patches is successful, intel#175 2. Apply llvm/clang patches together, intel#179 3. Exit CMake processing when apply_patches failed, intel#304 Signed-off-by: haonanya <[email protected]>
Signed-off-by: haonanya <[email protected]>
|
Hi, if there is no more further comments, I will merge it today. Thanks very much. |
wenju-he
approved these changes
Jan 25, 2022
haonanya
pushed a commit
that referenced
this pull request
Jan 25, 2022
* Improve patching mechanism This backports patches from other branches 1. Check if apply_patches is successful, #175 2. Apply llvm/clang patches together, #179 3. Exit CMake processing when apply_patches failed, #304 Signed-off-by: haonanya <[email protected]> * Skip the rest when apply patch failed Signed-off-by: haonanya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When git am operation, which is used to apply patches, fails for some reason during opencl-clang build, the build is continued.
This results in a opencl-clang package without all expected patches applied, it can cause its users to fail.
Signed-off-by: haonanya [email protected]