Remove patch for opencl-c.h #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all functions that use Image type should be wrapped by feature macro __opencl_c_images because some of these functions need to be available for OpenCL C 1.2 in which feature macro can not be set. Therefore this patch needs to be removed because it broke backward compatibility for OpenCL C 1.2 Additionally, fixed cross-compilation crash. The bug was added by PR intel#379
|
@hewj03 Could you please review this PR? |
wenju-he
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
LGTM. Is it right that you'll fix https://reviews.llvm.org/D103911 for the empty kernel crash issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all functions that use Image type should be wrapped by feature macro __opencl_c_images because some of these functions need to be available for OpenCL C 1.2 in which feature macro can not be set.
Therefore this patch needs to be removed because it broke backward compatibility for OpenCL C 1.2
More info llvm/llvm-project#58017
Additionally, fixed cross-compilation crash. The bug was added by PR #379