Lower -profiling option to -debug-info-kind=line-tables-only #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'-profiling' option aims source code view under VTune. Turning it on means that debug information will be generated and all optimizations will be made. Most of OpenCL transformation passes (vectorizer, barrier, etc.) work with debug information too offhandedly. To minimize risks to get debug information broken, let's generate it as less as possible. The patch also does other several things: 1. Update minimum cmake version to 3.13.4 to align with LLVM's cmake requirement. 2. Remove unused header and format code 3. Fix some build warnings
wenju-he
approved these changes
Jan 19, 2023
It's the follow up for preview patch to remove dwarf-column-info. On windows the presence of column info in the debug info causes undesirable stepping behavior in the Visual Studio debugger.
Correct. |
cdai2
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'-profiling' option aims source code view under VTune. Turning it on means that debug information will be generated and all optimizations will be made. Most of OpenCL transformation passes (vectorizer, barrier, etc.) work with debug information too offhandedly. To minimize risks to get debug information broken, let's generate it as less as possible.
The patch also does other several things: