[NFC] Improve for options_compile.cpp #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haonanya
commented
Mar 13, 2023
haonanya
commented
- Check return value for consume_front function
- Pass by reference to avoid copy StringRef
1. Check return value for consume_front function 2. Pass by reference to avoid copy StringRef
wenju-he
reviewed
Mar 13, 2023
wenju-he
reviewed
Mar 13, 2023
haonanya
force-pushed
the
small-improvement
branch
from
9a8cf9d to
bd796c6
Compare
wenju-he
reviewed
Mar 13, 2023
haonanya
force-pushed
the
small-improvement
branch
from
bd796c6 to
2b85b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.