Port "Enable use of GNU C extension - const statement expression as array size" #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray size" This patch partially reverts the commit: llvm/llvm-project@6781fee For backward compatibility, we still need to support the expressions like: ``` const int size = ({ false; }) ? 0 : 1; float array[size]; ``` https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html This is a cherry-pick of commit bf679f4 from CClang 14 branch.
|
do we need this on 16 branch? |
Good point - #459 created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch partially reverts the commit:
llvm/llvm-project@6781fee
For backward compatibility, we still need to support the
expressions like:
https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html
This is a cherry-pick of commit bf679f4 from CClang 14 branch.