-
Notifications
You must be signed in to change notification settings - Fork 82
Add 'clangSerialization' to CMakeLists (fix downstream link error). #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following link error occurs in downstream after 1bda00e: ``` ld: error: undefined symbol: clang::PCHContainerOperations::PCHContainerOperations() >>> referenced by opencl_clang.cpp >>> _deps/opencl-clang-build/CMakeFiles/common_clang.dir/opencl_clang.cpp.o:(Compile) icpx: error: linker command failed with exit code 1 (use -v to see invocation) ``` This is similar to the link error seen in https://reviews.llvm.org/D157078, which was resolved in the same way (https://reviews.llvm.org/rG36daf3532d91bb3e61d631edceea77ebb8417801). This patch just adds 'clangSerialization' to the link libraries to resolve the issue.
This fix is also urgent to unblock the downstream build. Pinging @hewj03, @haonanya for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tylanphear I just take a look at link.txt and it show opencl-clang is linking libclangSerialization.a |
|
Closing in favor of #476 |
after discussion with @zhaomaosu, we think this pr is probably the right fix although it is still unclear why clangSerialization is needed twice in link.txt. |
@tylanphear branch tylanphear:fix_downstream_link_error is deleted, could you please restore the branch and re-open this pr? |
Reopening as requested by @wenju-he. |
The following link error occurs in downstream after 1bda00e:
This is similar to the link error seen in
https://reviews.llvm.org/D157078, which was resolved in the same way
(https://reviews.llvm.org/rG36daf3532d91bb3e61d631edceea77ebb8417801).
This patch just adds 'clangSerialization' to the link libraries to
resolve the issue.