Improve triggering of AttemptedEdit source control action
#1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-rsingh
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug reported by an internal developer related to the firing of the
AttemptedEditsource control action. The developer reported that after reverting a file in the source control UI (not VS Code) when VS Code refreshed its copy of the file theAttemptedEditaction was incorrectly fired, and then upon the next edit to the file the action was not fired. I determined that this was due to thesuppressEditListenerMapthat was added to avoid firing the action when the file was reverted by the the source control hook. I fixed this issue by changing the criteria that were checked before firing the action so the map was no longer needed.