Skip to content

More client-side tweaks #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

More client-side tweaks #1571

merged 2 commits into from
Jun 9, 2025

Conversation

isc-bsaviano
Copy link
Contributor

This PR addresses feedback from a customer received via email.

  • Exempt files created due to server export from objectscript.autoAdjustName behavior.
  • Prevent rare case where a file may be compiled twice due to concurrency issues.
  • Improve code that exempts post-save compile from the batching behavior.

gjsjohnmurray
gjsjohnmurray previously approved these changes Jun 3, 2025
View reviewed changes
gjsjohnmurray
gjsjohnmurray approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but unverified as I don't routinely work client-side.

@isc-bsaviano
Copy link
Contributor Author

I tested this pretty heavily with the original issue reporter, and we are both happy with this in the current state.

@isc-bsaviano isc-bsaviano merged commit 61ced17 into intersystems-community:master Jun 9, 2025
5 checks passed
@isc-bsaviano isc-bsaviano deleted the client-side-tweaks branch June 9, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjsjohnmurray gjsjohnmurray gjsjohnmurray approved these changes

@isc-rsingh isc-rsingh Awaiting requested review from isc-rsingh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isc-bsaviano @gjsjohnmurray