Skip to content

Debugger improvements #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

isc-bsaviano
Copy link
Contributor

  • Fix the automatic termination of REST and unit test debug sessions (issue reported to the WRC)
  • Prevent VS Code from showing a Create File button for files that are deployed (issue reported to the WRC)
  • Don't attempt to set a breakpoint that's from a file in a different workspace folder
  • Fix debugging files in a client-side virtual workspace folder
  • Explicitly report failure to set a breakpoint
  • Use the document index to get determine the name of a document in a local file
  • Cache the contents of files fetched during a debug session

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I assume you'll get it tested by those who reported the issues it's intended to fix.

@isc-bsaviano
Copy link
Contributor Author

The customer has not verified this fix, but their setup was easy to replicate so I tested this myself. You can verify this yourself easily if you want. Just pull a 2025.1 community container, create a REST web app and dispatch class, then try to debug it. You'll see that it breaks in %SYS.cspServer instead of terminating automatically.

@gjsjohnmurray
Copy link
Contributor

Happy to defer to your testing.

@isc-bsaviano isc-bsaviano merged commit dad6746 into intersystems-community:master Jun 9, 2025
5 checks passed
@isc-bsaviano isc-bsaviano deleted the debugger branch June 9, 2025 16:07
@mloutraris
Copy link

We were also experiencing this issue and I have pulled the beta build and it no longer pops up the create file which was our major issue in the WRC that we created.

@isc-bsaviano
Copy link
Contributor Author

Thanks for confirming @mloutraris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants