Skip to content

Alert on import error #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2020
Merged

Alert on import error #173

merged 1 commit into from
Jul 1, 2020

Conversation

ty-d
Copy link
Contributor

@ty-d ty-d commented Jun 29, 2020

Add alerts in the bottom right when importing fails. The read-only error will now appear in the bottom right instead of a modal.

@ty-d ty-d requested review from isc-rsingh and gjsjohnmurray June 29, 2020 14:03
@ty-d ty-d requested a review from daimor as a code owner June 29, 2020 14:03
gjsjohnmurray
gjsjohnmurray approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isc-rsingh isc-rsingh merged commit b58e16f into intersystems-community:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daimor daimor daimor approved these changes

@isc-rsingh isc-rsingh isc-rsingh approved these changes

@gjsjohnmurray gjsjohnmurray gjsjohnmurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ty-d @daimor @isc-rsingh @gjsjohnmurray