Skip to content

Added diagnostic to warn if non-latin characters found in class elements #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2020
Merged

Added diagnostic to warn if non-latin characters found in class elements #180

merged 1 commit into from
Jul 7, 2020

Conversation

daimor
Copy link
Member

@daimor daimor commented Jul 6, 2020

closes #112

gjsjohnmurray
gjsjohnmurray approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isc-rsingh isc-rsingh self-requested a review July 7, 2020 02:24
@isc-rsingh isc-rsingh merged commit 1701341 into master Jul 7, 2020
@daimor daimor deleted the #112-diagnostic-non-latin branch July 7, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-rsingh isc-rsingh isc-rsingh approved these changes

@gjsjohnmurray gjsjohnmurray gjsjohnmurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SqlComputeCode breaks formatting
3 participants
@daimor @isc-rsingh @gjsjohnmurray